wwqgtxx：forwardICMP 的改动存在阻塞风险
作者原文@wwqgtxxAs a side note, I don't think the changes in the second commit are entirely sound. The
forwardICMPsection, in particular, appears to boost performance but introduces greater risk. In reality, theICMPForwarderHandlershould return as quickly as possible and avoid any blocking or long-running operations internally; clearly,PrepareConnectionoffers no guarantee against blocking.Furthermore, I don't quite understand the addition of
s.icmpMuthere;DirectRouteMappingis already thread-safe, so what is the purpose of wrapping it in an external lock?