alireza0:3x-ui CI 应补跑 PostgreSQL 测试并保留主线 gate
alireza0 在 3x-ui PR #6917 说明,XUI_TEST_PG_DSN 保护的迁移测试实际从未在 CI 跑过;要求通过 scratch 数据库接入,并在 rebase 时保留主线新增 PostgreSQL 测试。评论还指出 npm audit 依赖网络和实时 advisory 数据库,应留在 CI 而不是 make verify,以保持本地 gate 可复现。PR 当时仍待合并。
作者原文@alireza0Thanks, wiring the
XUI_TEST_PG_DSNtests into a scratch-database job closes a real hole. I checked that every test you name exists on main and is currently run by no workflow.Before merge:
1. Rebase onto main and keep main's Postgres entries. The branch conflicts with main. While it was open, main added these to the Postgres job:
TestClientKeepAlivePostgresMigrationPreservesLegacyScalars(schema step, which now expects 5);- a
TestSubHostOrder_Postgresstep;- a Telegram lookup step with
TestGetClientTrafficTgBot_IndexedPostgresandTestGetClientTrafficTgBot_SettingsSerializationStyles.None of these are in this branch's
ci.yml. Please keep them through the rebase and adjust the pass counts, or the PR would silently drop tests from CI again.2. Please keep
audit-feout ofmake verify.npm auditdepends on the network and on a live advisory database, so an unchanged commit can passverifytoday and fail tomorrow. That is the same drift the golangci-lint pin removes. Keeping the audit in the CIfrontendjob (as the newnpm run auditscript) is enough.3. Minor,
x-ui.sh: switching to-gtis right, but the description is off. Inside[[ ]],"10" > "1"is true lexicographically (same prefix, longer string), so no argument count was actually mis-compared. Please reword the commit as astyle/correctness cleanup rather than a bug fix.